You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #116856 I noticed a weird relationship between the IEditorService' responsibility of registerCustomEditorViewTypesHandler, the fact that editorOpenWith.ts manages the workbench.editorAssociations setting and the truth that only custom editors and notebooks seem to pick up on the setting.
In #116856 I have moved the handling of workbench.editorAssociations into vs/workbench/browser/editor.ts as an editor associations factory because I felt the editor service was the wrong place for it.
However, if the only client of this setting is the custom editor service, I would suggest to move it somewhere there. And if not, I would suggest to move code of custom editor handling into workbench core. Specifically CustomEditorInfo and selectorMatches etc.
I think my preference would be to move the factory code into the custom editor contrib and let notebooks use it from there. If you feel strong about moving it back into a service, feel free to add it to custom editor service.
The text was updated successfully, but these errors were encountered:
I have moved this code into the override service (190e902) as that is the only time it would need to be respected. Let me know if that's sufficient for you.
While working on #116856 I noticed a weird relationship between the
IEditorService
' responsibility ofregisterCustomEditorViewTypesHandler
, the fact thateditorOpenWith.ts
manages theworkbench.editorAssociations
setting and the truth that only custom editors and notebooks seem to pick up on the setting.In #116856 I have moved the handling of
workbench.editorAssociations
intovs/workbench/browser/editor.ts
as an editor associations factory because I felt the editor service was the wrong place for it.However, if the only client of this setting is the custom editor service, I would suggest to move it somewhere there. And if not, I would suggest to move code of custom editor handling into workbench core. Specifically
CustomEditorInfo
andselectorMatches
etc.I think my preference would be to move the factory code into the custom editor contrib and let notebooks use it from there. If you feel strong about moving it back into a service, feel free to add it to custom editor service.
The text was updated successfully, but these errors were encountered: