Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthenticationProviderAuthenticationSessionsChangeEvent.changed: clarify what can change #117414

Closed
aeschli opened this issue Feb 23, 2021 · 0 comments
Closed

AuthenticationProviderAuthenticationSessionsChangeEvent.changed: clarify what can change #117414

aeschli opened this issue Feb 23, 2021 · 0 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2021

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 23, 2021

Testing #117299

AuthenticationProviderAuthenticationSessionsChangeEvent.changed signals that a AuthenticationSession has changed.
Can the spec clarify what can change? Can e.g. the account change? Everything but the id? (in that case it has to be a remove/add)

Is the session object in the event reflecting the changed state?
@aeschli aeschli mentioned this issue Feb 23, 2021
Closed
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2021
@RMacfarlane RMacfarlane added this to the February 2021 milestone Feb 24, 2021
@aeschli aeschli added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@RMacfarlane @aeschli and others