Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"... wants to sign in" dialog uses auth provider ID, not label #117461

Closed
roblourens opened this issue Feb 23, 2021 · 0 comments
Closed

"... wants to sign in" dialog uses auth provider ID, not label #117461

roblourens opened this issue Feb 23, 2021 · 0 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2021

Comments

@roblourens
Copy link
Member

Testing #117299

It seems like this should use the label, not the ID:

image

I registered my provider like this:

vscode.authentication.registerAuthenticationProvider('testAuthProvider', 'My Cool Auth Provider', new AuthProvider());
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2021
@RMacfarlane RMacfarlane added this to the February 2021 milestone Feb 23, 2021
@roblourens roblourens added the verified Verification succeeded label Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@roblourens @RMacfarlane and others