Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make added, removed, changed, optional in auth session change event #117469

Closed
roblourens opened this issue Feb 23, 2021 · 2 comments
Closed

Make added, removed, changed, optional in auth session change event #117469

roblourens opened this issue Feb 23, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Testing #117299

Minor thing, but implementing this, I noticed that it would be nice for added, removed, and changed, to be optional properties on the change event that the extension has to construct, because it's likely that only one of them is relevant at a time.

readonly added: ReadonlyArray<AuthenticationSession>;

@RMacfarlane
Copy link
Contributor

Makes sense to me, but we seem to have a pattern of requiring these on other change events. For example BreakpointsChangeEvent and WorkspaceFoldersChangeEvent also have added/removed as required. @jrieken @mattbierner Any thoughts on this/historical reasons? Do we care about being consistent with these?

@jrieken
Copy link
Member

jrieken commented Feb 24, 2021

I think it makes sense. The difference between BreakpointsChangeEvent and AuthenticationProviderAuthenticationSessionsChangeEvent is that the latter is created by us (and therefore should be complete and easy to work with) and the former is provided by the provider (and therefore should be easy to construct). This goes along the lines of this: https://github.com/microsoft/vscode/wiki/Extension-API-guidelines#strict-and-relaxed-data

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2021
@RMacfarlane RMacfarlane added this to the February 2021 milestone Feb 24, 2021
@roblourens roblourens added the verified Verification succeeded label Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @jrieken @RMacfarlane and others