Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single custom editor does not split #117541

Closed
sana-ajani opened this issue Feb 24, 2021 · 3 comments
Closed

Single custom editor does not split #117541

sana-ajani opened this issue Feb 24, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach

Comments

@sana-ajani
Copy link
Contributor

Testing #117279

Open a single .png file using the Hex Editor. In the command palette, enter "view: split editor" and choose any of the options. Nothing happens when I try to split the editor using the command palette or using the split icon in the top right. I compare this to the experience using the text editor or custom notebook editor, where running this command on a single file opens up the same file in the split mode.

@sana-ajani sana-ajani changed the title Custom editors do not split with View: Split Editors command Single custom editor does not split with View: Split Editors command Feb 24, 2021
@mjbvz mjbvz assigned lramos15 and unassigned mjbvz Feb 24, 2021
@sana-ajani sana-ajani changed the title Single custom editor does not split with View: Split Editors command Single custom editor does not split Feb 24, 2021
@lramos15
Copy link
Member

This appears to get fixed by #120263 whenever that goes in

@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach labels Apr 1, 2021
@lramos15
Copy link
Member

lramos15 commented Apr 1, 2021

This actually isn't fixed by that PR. The issue here is when you hit the split icon on an editor that doesn't support splitting and it's the only one in the editor group, then what should happen? You see nothing happen because it's creating a new group moving the editor to the new group and deleting the old group all in that moment. Should we hide the commands in this case, is nothing expected, should we show a notification?

@lramos15
Copy link
Member

lramos15 commented Apr 7, 2021

Discussed during the UX sync. This will be fixed by #120263 so closing now as we have a similar issue tracking the weird split behavior.

@lramos15 lramos15 closed this as completed Apr 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants