Trusted workspaces and extension installation

[kieferrm]

When using trusted workspaces as described in #106488.

1. Install an extension that requires trust on startup
2. Close the dialog that shows up; i.e. don't make a decision about trust

-> extension is not installed
-> window shows in "unknown" trust state

That the extension is not installed is unexpected. I would have assumed that the extension is installed but is not activated.

[sbatten]

I have the same feeling. I tried to install an extension for testing and was not in a repo I "trusted", but was going to switch after I installed the extension. You are pretty much forced into trusting the current workspace to install an extension which isn't really the gate we are going for.

[lszomoru]

Adding @sandy081 since this flow impacts extension acquisition

At the moment, the user gesture that requires workspace trust is the gesture to install an extension. This means that any choice other than trusting the workspace will result in the extension not getting installed. I do see how this can cause confusion as you might be getting the dialog depending on the workspace that is currently opened. I am inclined to updating the flow so that:

• Extension(s) would successfully get installed independent of workspace trust state
• If extension requires trust onStart and the workspace is in trusted state:
  • Extension would be enabled
• If extension requires trust onStart and the workspace is in untrusted state:
  • Extension would not get enabled
  • No notification would be shown
• If extension requires trust onStart and the workspace is in unknown trust state:
  • Extension would not get enabled
  • A soft workspace trust request (activity bar item badge) would be shown

[sbatten]

For the flow where a notification is shown, we may wish to promote this to a dialog as the user is more likely than not expecting the extension they just installed to work immediately

[lszomoru]

Independent whether the extension is installed from the Extensions list or the Extension editor, there will be an immediate visual indicator (shield icon + tooltip/message) that the extension is disabled due to workspace trust requirement. Clicking enable button to enable the extension would show the dialog.

[sbatten]

It is possible though that the user already has something requesting trust "softly" so there may not be a new visual indication. Because of that and the fact this this isn't "on load" but rather during the explicit action of installing the extension, it may be a candidate for a more immediate request for trust

[lszomoru]

I think that we can experiment with both soft and modal notifications. The big takeaway from this issue is that the action that requires workspace trust is "enabling" the extension after it has been installed. Independent of the workspace trust state, the extension should get installed. If we are all on-board with that, I will make the necessary changes.

[lszomoru]

@sandy081, any input on this? Thanks!

[sandy081]

This flow seems to be new to users, at present we allow installing extensions if they can run otherwise we do not. For eg., we do not allow installing an UI extension in web and we show a dialog immediately. In this case, one difference is that no user action will help in running the extension. In case of trusted workspace, user taking an action (say I trust this workspace) will allow running the extension. I agree that not showing any information that is on user face will confuse them why this extension is not enabled. So, I would either

• After installing, show a dialog that extension(s) are disabled because.. (remember it can be a pack of extensions or has extension dep that needs trusted)
• While installing, show a dialog that extension(s) need trusted workspace and provide following options
  • Trust Workspace & Install
  • Install Anyway
  • Cancel

IMO the second flow seems nicer for user because user knows what will happen before rather after the action.

[lszomoru]

Thanks @sandy081! I do like the second flow as well.

[lszomoru]

This has been checked in to main.