Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification filter by extension source #118249

Closed
JCKodel opened this issue Mar 5, 2021 · 3 comments
Closed

Notification filter by extension source #118249

JCKodel opened this issue Mar 5, 2021 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@JCKodel
Copy link

JCKodel commented Mar 5, 2021

There are many many VSCode extensions that abuse or displays wrong notifications. Sometimes, the notification is useless and spammy, sometimes, it is just bugged.

Examples:
image

Those 2 notifications pops up every time I save a file in VSCode. There is a bug on dart-import extension and the project seems dead (but the extension is still useful and relevant).

image

In this case, the notification is useless. When triggering this extension on save, those notifications fills the entire queue and occupy the bottom space of the screen.

I had to install a 3rd extension just to fix things on save:

"multiCommand.commands": [
  {
    "command": "multiCommand.fixAndSave",
    "interval": 250,
    "sequence": [
      "dart-import.fix",
      "workbench.action.files.save",
      "notifications.hideToasts"
    ]
  },
],

If the extenion is .dart, I call the dart-import extension to do its magic, then I save the file, then I hide all toasts to clear the spam (and losing useful toasts, if there is any).

It is impossible to ask for each extension developer to not misuse the notification system, nor can I fork and fix EVERY extension I use, so...

What I'm proposing is something like this:

hideToastsFromExtensions: {
  "dart-import": "block",
  "some-other-extension": "hide"
}

block will prevent that extension of showing toasts (nothing happens, the toasts simply doesn't appear, hidden or not).
hide will not display the notification on screen, but will trigger the unread notification icon:
image

@sana-ajani
Copy link
Contributor

cc @devinvalenciano @meganrogge

@gjsjohnmurray
Copy link
Contributor

/duplicate of #41767

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@JCKodel @bpasero @gjsjohnmurray @sana-ajani and others