Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started actions should account for actions from the UI #118274

Closed
miguelsolorio opened this issue Mar 5, 2021 · 7 comments
Closed

Getting started actions should account for actions from the UI #118274

miguelsolorio opened this issue Mar 5, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) getting-started under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Mar 5, 2021

image

  1. Create codespace
  2. Terminal is open by default
  3. Navigate to "Ports" view
  4. 🐛 Getting started displays the "view ports" step as incomplete

I didn't use any commands and the "port" view was already moved into my panel. Also, I had already ran actions in the terminal as well so that step should checked.

fyi @digitarald

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug getting-started labels Mar 5, 2021
@JacksonKearl
Copy link
Contributor

It only checks off by running the command right now, so if you open it from the UI it wont (but if you use the keybinding it should). Since we now support manually clicking the item to check it off do you think we need to also have a way to listen in to clicks for automated checking off?

@JacksonKearl JacksonKearl added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 29, 2021
@miguelsolorio
Copy link
Contributor Author

Ideally it would check off no matter what route you take, that gives you a nice overall experience. When I went through this step, it felt like a bug that it wasn't checked after I navigated to it.

@digitarald
Copy link
Contributor

In cases where the UI is already visible I also thought to use when clauses to hide the task. The buttons for those cases will always be a bit awkward, as the click will not have any visible reaction; and the user already has found the UI without help from the walkthrough.

Alternatively, a task could also highlight a related UI element; something we discussed in the past that makes it easier to use walkthroughs for UI tours.

@miguelsolorio
Copy link
Contributor Author

I don't think we want to hide items when they are visible, in my case the terminal was already open and then I clicked on the "Ports" panel. It's more about providing different avenues for the user to complete the task.

@digitarald
Copy link
Contributor

Right, I was mixing up issues here! Agreed that these kind of UI tasks should still be checked off even when not using the given command.

@miguelsolorio
Copy link
Contributor Author

Created #120147 to track exploring hints, with I discussed with Kai today

@JacksonKearl JacksonKearl added this to the April 2021 milestone Mar 30, 2021
@JacksonKearl JacksonKearl modified the milestones: April 2021, May 2021 Apr 28, 2021
@JacksonKearl
Copy link
Contributor

Duplicate of #122570

@JacksonKearl JacksonKearl marked this as a duplicate of #122570 May 4, 2021
@JacksonKearl JacksonKearl added the *duplicate Issue identified as a duplicate of another issue(s) label May 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) getting-started under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants