Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Use Built-in TypeScript Semantic Highlighting #119309

Closed
3 tasks done
aeschli opened this issue Mar 19, 2021 · 0 comments
Closed
3 tasks done

Test: Use Built-in TypeScript Semantic Highlighting #119309

aeschli opened this issue Mar 19, 2021 · 0 comments
Assignees
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 19, 2021

Refs: #119139

Complexity: 2

Create Issue


  • open a typescript file

  • verify in the status bar that typescript version 4.2 or newer is used

  • open the TS log (Command: TypeScript: Open TS Log...) (might have to do it twice after the restart the TS service)

  • In the log, look for the content typescript-vscode-sh-plugin not active for version >= 4.2

  • use one of the built in themes (or one that has semantic highlighting enabled (if you know))

  • Set a cursor on a variable or other symbols and use the Developer: Inspect Editor Tokens and Scope command to investigate whether semantic tokens are available. If it does, the hover has a section semantic token types

  • A easy way to see whether semantic highlighting works is: use default Dark/Light theme and verify that constant variables have a slightly different color than other variables.

  • Do some general testing around semantic tokens. E.g. Open large files, scrolling around, validate updating after modifications

  • Switch to an other version of TypeScript by opening a folder with package.json depending an typescript < 4.2 and clicking on the version indicator in the status bar

  • Check the TS log, low it will say typescript-vscode-sh-plugin initialized. Intercepting getEncodedSemanticClassifications and getEncodedSyntacticClassifications.

@aeschli aeschli added this to the March 2021 milestone Mar 19, 2021
@ghost ghost assigned mjbvz, lszomoru and RMacfarlane Mar 23, 2021
@lszomoru lszomoru removed their assignment Mar 23, 2021
@RMacfarlane RMacfarlane removed their assignment Mar 23, 2021
@mjbvz mjbvz closed this as completed Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants