Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug view should show when a breakpoint is hit #119646

Closed
Tyriar opened this issue Mar 23, 2021 · 5 comments
Closed

Debug view should show when a breakpoint is hit #119646

Tyriar opened this issue Mar 23, 2021 · 5 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2021

Testing #119545

I don't think I have a setting that would influence this, I expected the debug pane to show on break so I could action the breakpoint.

Repro:

  1. Create a breakpoint
  2. Close file
  3. Start debugging that test, on breakpoint hit the debug view won't be shown

recording (6)
@connor4312
Copy link
Member

connor4312 commented Mar 23, 2021 •
edited
Loading

@isidorn I think this is something that should happen for all debug sessions if the user has the debug toolbar inline.

@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 23, 2021
@isidorn isidorn added the feature-request Request for new features or functionality label Mar 23, 2021
@isidorn isidorn added this to the April 2021 milestone Mar 23, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2021

Yes, this feature makes sense.
We can open the debug view when a breakpoint is hit. Especially if the toolbar is docked

@weinand
Copy link
Contributor

weinand commented Mar 29, 2021

And with the new DAP feature we can even highlight the breakpoint(s) causing the hit.

@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2021

We have a setting debug.openDebug which by default is openOnFirstSessionStart. I have changed the default to be openOnDebugBreak so that on every breakpoint hit we open the debug view. We will also open the debug view on first session start.

For the new DAP feature we can tackle that via #118743

@isidorn isidorn added the verification-needed Verification of issue is requested label Mar 30, 2021
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Apr 22, 2021
@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2021

@Tyriar can you please verify this one? Thanks!

@Tyriar Tyriar added the verified Verification succeeded label Apr 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
5 participants
@weinand @isidorn @Tyriar @connor4312 and others