Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added correct syntax highlight for -ms-viewport and -o-viewport. #120374

Closed
george-tr6 opened this issue Apr 1, 2021 · 3 comments
Closed

I added correct syntax highlight for -ms-viewport and -o-viewport. #120374

george-tr6 opened this issue Apr 1, 2021 · 3 comments
Assignees
Labels
grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@george-tr6
Copy link

I added correct syntax highlight for -ms-viewport and -o-viewport.

Originally posted by @octref in #54515 (comment)

@george-tr6
Copy link
Author

I see the same issue after the latest update Version: 1.55.0.
Previous issue related to this bug was #54515

@aeschli aeschli assigned alexr00 and unassigned aeschli Apr 7, 2021
@alexr00
Copy link
Member

alexr00 commented Apr 7, 2021

We recently moved to a different CSS grammar for providing syntax highlighting. The old one was unmaintained, and the new one has good fixes in it. You can see the full discussion here: #115480

Specifically, see #115480 (comment), which references viewport as a deprecated feature (details https://developer.mozilla.org/en-US/docs/Web/CSS/@viewport). Even though the new grammar is missing ms-viewport, we decided to go with it because the benefits of having a maintained grammar outweighed the negative of missing the deprecated ms-viewport.

If you feel strongly that this is essential for the grammar, I recommend going to https://github.com/atom/language-css/, the repo that we pull our css grammar from, and filing an issue there to ask for ms-viewport to be supported in their textmate grammar.

@alexr00 alexr00 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) grammar Syntax highlighting grammar labels Apr 7, 2021
@alexr00 alexr00 closed this as completed Apr 7, 2021
@george-tr6
Copy link
Author

Thank you for the detailed explanation Alex!
I was using this feature for emails and as we know the email coding is kind of stuck in the past :)
I will work on retiring this deprecated feature in my code as it seems that it is not essential anymore.

Thanks again and have a great day!

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants