Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desktop.ini to the default files.exclude list #121006

Closed
tpiekarski opened this issue Apr 10, 2021 · 2 comments
Closed

Add desktop.ini to the default files.exclude list #121006

tpiekarski opened this issue Apr 10, 2021 · 2 comments
Assignees
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@tpiekarski
Copy link

Visual Studio Code have a default set of excluded files:

"files.exclude": {
  "**/.git": true,
  "**/.svn": true,
  "**/.hg": true,
  "**/CVS": true,
  "**/.DS_Store": true
}

I would like to ask if we could add desktop.ini (and maybe thumbs.db as well) to this default list?

desktop.ini files are created by the Windows Explorer when you customize a directory (for example adding a custom icon). For details please refer to How to Customize Folders with Desktop.ini.

This file is imho a counterpart to the already added .DS_Store used on macOS.

In the Apple macOS operating system, .DS_Store is a file that stores custom attributes of its containing folder, such as the position of icons or the choice of a background image.
https://en.wikipedia.org/wiki/.DS_Store

Should you agree with me, I would like to provide this little PR as my first one 😃

@isidorn
Copy link
Contributor

isidorn commented Apr 12, 2021

While this suggestion makes sense, changing the default can be quite unexpected to some users as some of their files might disappear.
I suggest to leave this open for now and if nobody objects and there are more interested users than we can add it.
Thanks

fyi @bpasero

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Apr 12, 2021
@isidorn isidorn added this to the Backlog milestone Apr 12, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @tpiekarski and others