Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build related terminals do not restore on reload #122171

Closed
bpasero opened this issue Apr 26, 2021 · 1 comment
Closed

Build related terminals do not restore on reload #122171

bpasero opened this issue Apr 26, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@bpasero
Copy link
Member

bpasero commented Apr 26, 2021

Steps to Reproduce:

  1. have tabs enabled
  2. run our default build task (it opens 2 terminals)
  3. apply insiders update

=> 🐛 the terminals do not restore

Before
image

After
image

//cc @alexr00 I wonder if we actually terminate these terminals on shutdown?
@bpasero bpasero changed the title Terminals do not restore anymore Build related terminals do not restore on reload Apr 26, 2021
@alexr00
Copy link
Member

alexr00 commented Apr 26, 2021

Since there is work required from tasks to handle this, we currently deliberately don't restore terminals that belong to tasks. Duplicate of #117408

@alexr00 alexr00 closed this as completed Apr 26, 2021
@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bpasero @Tyriar @meganrogge @alexr00