Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and delete in explorer should have ... since they need additional info #122316

Closed
Tyriar opened this issue Apr 27, 2021 · 7 comments · Fixed by #158296
Closed

Rename and delete in explorer should have ... since they need additional info #122316

Tyriar opened this issue Apr 27, 2021 · 7 comments · Fixed by #158296
Assignees
Labels
file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue ux User experience issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2021

Related: #122296

Both need additional info:

Screen Shot 2021-04-27 at 4 55 10 AM

@isidorn
Copy link
Contributor

isidorn commented Apr 27, 2021

Any change I do in the explorer raises a user revolt. So could do this start of next milestone.
Delete does not require additional user input (if I say do not ask again for prompt).

So I think only Rename should be Rename...
However I would wait for the editor to change Rename Symbol to be Rename Symbol... so they are aligned.
fyi @jrieken

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Apr 27, 2021
@jrieken
Copy link
Member

jrieken commented Apr 27, 2021

Not so sure about the ... rules

Screenshot 2021-04-27 at 14 36 26

@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2021

Finder is inconsistent; "Tags..." opens an inline pop similar to rename, but rename doesn't have the .... It might not be the best example.

@Tyriar Tyriar added the ux User experience issues label Apr 27, 2021
@miguelsolorio
Copy link
Contributor

Using ... on actions when needing user input has been a consistent pattern we've used for named actions. So we should try to keep it consistent.

@isidorn isidorn assigned JacksonKearl and unassigned isidorn Aug 12, 2021
@JacksonKearl JacksonKearl added this to the On Deck milestone Aug 13, 2021
@lramos15 lramos15 assigned lramos15 and unassigned JacksonKearl May 25, 2022
@lramos15 lramos15 added polish Cleanup and polish issue and removed under-discussion Issue is under discussion for relevance, priority, approach labels May 27, 2022
@lramos15 lramos15 modified the milestones: On Deck, June 2022 May 27, 2022
@lramos15
Copy link
Member

Will take this in start of next milestone

@lramos15 lramos15 modified the milestones: June 2022, July 2022 Jun 22, 2022
@lramos15 lramos15 modified the milestones: July 2022, August 2022 Jul 20, 2022
@lramos15
Copy link
Member

@misolori From a UX perspective it appears ... is used when a quick input is present but not when an inline edit widget is. So I believe that's why things like Rename and Rename Symbol do not have ..., so is the UX guideline that inline edit widgets also should have ...?

@miguelsolorio
Copy link
Contributor

I would say that any action that requires user input should use the ....

I am seeing the same for toolbar actions like new file/folder in the tooltip as well while the quick pick and app menu do show it.

CleanShot 2022-08-16 at 08 45 32@2x

CleanShot 2022-08-16 at 08 45 40@2x

CleanShot 2022-08-16 at 08 45 47@2x

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 16, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants