Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoReveal, but only when a file is explicitly selected #123020

Closed
Rich-Harris opened this issue May 5, 2021 · 2 comments
Closed

autoReveal, but only when a file is explicitly selected #123020

Rich-Harris opened this issue May 5, 2021 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@Rich-Harris
Copy link

This is a repeat of #38899, which I think was closed erroneously as a dupe of #23902 — I can't reopen it because I missed the window before the bot locked it. The original comment, for convenience:

Per #3062, the explorer.autoReveal setting controls whether the explorer will jump to the active file whenever it changes. That's good, because autoReveal is infuriating when the active file changes as a result of a tab being closed (whether because the user hit Cmd-W or clicked the 'x', or because the file was deleted via the explorer).

But autoReveal can be very useful when the active file changed because the user explicitly selected an existing tab.

I'd like to propose a third option besides "explorer.autoReveal": true and "explorer.autoReveal": false — perhaps something like "explorer.autoRevealSelected": true? With this option, clicking on a tab in the main view (even for the currently active file) would reveal the file in the explorer.

The "explorer.autoReveal": "focusNoScroll" setting added since this issue was initially raised doesn't solve it: the ideal behaviour is for the explorer to scroll to a file that was explicitly selected by the user, i.e. by clicking on a tab or cmd-clicking in the terminal or using Cmd-P, etc. Framed differently, the explorer shouldn't scroll to the active file (and expand all parent folders, which is very annoying!) if it only became active because a different file was closed. Thank you.

@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels May 6, 2021
@isidorn isidorn added this to the Backlog milestone May 6, 2021
@isidorn
Copy link
Contributor

isidorn commented May 6, 2021

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog and we might add this in the future. Thanks

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@Rich-Harris @isidorn and others