Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revel in File Explorer shortcut select wrong file #124005

Closed
ShuiRuTian opened this issue May 17, 2021 · 2 comments
Closed

Revel in File Explorer shortcut select wrong file #124005

ShuiRuTian opened this issue May 17, 2021 · 2 comments
Assignees
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@ShuiRuTian
Copy link

ShuiRuTian commented May 17, 2021

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.56.0
  • OS Version: 10.0.18363

Steps to Reproduce:

  1. prepare file "root/file1" and "root/fodler/file2"
  2. open "root" as root folder.
  3. open "file2", so we could edit it
  4. right click "file1" in EXPLORER, we could see "Revel in File Explorer Shift + Alt + R"
  5. use the shortcut "Shift + Alt + R"

You would see the open file explorer which selects editing file(file2) rather than the real file I want to open(file1)
And, use mouse to click could open the correct file.

The shortcut(Shift + Alt + R) has nothing to do is more consistent with other shortcuts. However, open the wrong file is a bad choice I think.

@isidorn
Copy link
Contributor

isidorn commented May 17, 2021

@ShuiRuTian yeah, reveal in Explorer reveals the file which is focused in the explorer if the focus is in the explorer. If the focus is in the editor area than that file will be revealed.

I would not change anything here as this is how users are used to use this command.
However I can leave this open for now to gather more feedbck

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels May 17, 2021
@isidorn isidorn added this to the Backlog milestone May 17, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @ShuiRuTian and others