Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: should not offer drop feedback in multi-root case when last folder readonly #124495

Closed
bpasero opened this issue May 24, 2021 · 2 comments
Assignees
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@bpasero
Copy link
Member

bpasero commented May 24, 2021

Steps to Reproduce:

  1. be in a multi root workspace
  2. let the last folder be a readonly one
  3. drag and drop files into the empty space after the last folder
  4. you get visual feedback that you can drop

=> 🐛 this is not true because by default we seem to be dropping into the last folder when dropping into empty space

I am not even sure we can do this properly because obviously we do want to allow to drop folders since the user may want to add to the workspace. Alternatively if we cannot disable the drop feedback, maybe a dialog should appear.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels May 24, 2021
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label May 24, 2021
@isidorn
Copy link
Contributor

isidorn commented May 25, 2021

As you say we can not disable the drop feedback since the user might want to drop another root folder.
Probably the right experience would be to polish the dialog which asks the user does he want to Copy / Paste or Add a Root folder. That dialog should probably say, you can only add a root folder since root R is readonly.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @isidorn and others