Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Request - Move files in File Explorer Sidebar for keyboard users #124775

Closed
garrettbsettles opened this issue May 27, 2021 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@garrettbsettles
Copy link

Problem:
Currently to move files in and out of folders in side bar file explorer, a user must use a mouse to drag and drop files into desired folder. This poses an accessibility issue to keyboard users - If a user cannot use a mouse, a user cannot drag and drop files.

Solution:
When File Explorer Side Bar is focused, move files up or down with keyboard shortcuts option up or down or with Command Palette "Move File Up" "Move File Down". If Move file up is selected, it will move the file first to the next closest shown folder. If the folder is focused and collapsed, it will be expanded. However, folders that were expanded will collapse once they are no longer focused. As long as the option key is depressed, the file selected for the move will move into each folder directly underneath the containing folder name when the up or down arrow keys are depressed, ignore file name sort order until option key is no longer pressed, at which point the view will focus on the file that has been moved and its position with the folder's file list will be correctly sorted.

Notes
It would be easier to implement "Move File Next (Sibling) Folder", "Move File Previous (Sibling) Folder", "Move File Up Folder (Level)", "Move File Down Folder (Level)", however users are used to using option up or down to move lines in the code editor, and expecting the same / similar behavior in the file explorer would increase user adoption. Or perhaps an alternative solution could be-

"Move File Next (Sibling) Folder" - option down
"Move File Previous (Sibling) Folder" - option up
"Move File Down Folder (Level)" - option right
"Move File Up Folder (Level)" - option left

Something is better than the current status quo though which leaves keyboard users out

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels May 28, 2021
@isidorn
Copy link
Contributor

isidorn commented May 28, 2021

@garrettbsettles thanks for your feedback.

If you want to move files around the explorer why is the following scenario not working for you: press Ctrl + X to cut files, then use the keyboard to move to the destination and press Ctrl + V to paste them?

@garrettbsettles
Copy link
Author

@isidorn ah - your recommendation is exactly what I was looking for - thank you.

Also, I tried looking for documentation online for moving files around via the keyboard but couldn't find anything. Could you post a link to the documentation where it mentions moving files around via the keyboard? I think it could help with future users who run into a similar issue.

@isidorn
Copy link
Contributor

isidorn commented May 28, 2021

@garrettbsettles we do not currently mention it in our docs between that keybinding is pretty common when using file explorer.
However if you are passionate about this we accept PRs that improve our docs https://github.com/microsoft/vscode-docs

I will close this for now since no code changes are planned here

@isidorn isidorn closed this as completed May 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants