Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable math rendering in standard markdown preview #124783

Closed
mjbvz opened this issue May 27, 2021 · 4 comments
Closed

Enable math rendering in standard markdown preview #124783

mjbvz opened this issue May 27, 2021 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 27, 2021

Feature request

We now ship support for rendering math equations inside of markdown for notebooks. However this is currently disabled for normal markdown source code

It would be great to enable this rendering for the normal markdown preview too. A few notes:

  • There needs to be a simple way to turn off this feature
  • We also need a bit more testing of the rendering in insiders to make sure it doesn't cause any weird issues (specifically we want to make sure markdown with $ that should not be part of a math equation doesn't do weird things)
@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels May 27, 2021
@mjbvz mjbvz added this to the June 2021 milestone May 27, 2021
@mjbvz mjbvz self-assigned this May 27, 2021
@mjbvz mjbvz closed this as completed in 0a57fd8 Jun 8, 2021
@rzhao271
Copy link
Contributor

@mjbvz can you provide some verification steps for this issue?
Using the experimental iframe, the results seem off:

mathpreviewweird

@rzhao271 rzhao271 added verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification labels Jun 29, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 30, 2021

Try grabbing an equation from the katex docs:

$$
c = \pm\sqrt{a^2 + b^2}
$$

Should be working in the next insiders (Thursday)

@weinand
Copy link
Contributor

weinand commented Jun 30, 2021

Works fine for me:

2021-06-30_15-45-27

@Yue-Zhengyuan
Copy link

Yue-Zhengyuan commented Jul 10, 2021

Will VS Code natively support KaTeX custom macros (see this documentation) in near future? (Although there exists 3rd party extensions like this one providing this feature, but currently they cannot work with the built-in math rendering of VS Code, i.e. I need to use KaTeX provided by these extensions instead of the built-in one.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @rzhao271 @mjbvz @Yue-Zhengyuan and others