Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview: shows a "Not implemented" warning when triggering search #125118

Closed
bpasero opened this issue Jun 1, 2021 · 2 comments
Closed

Webview: shows a "Not implemented" warning when triggering search #125118

bpasero opened this issue Jun 1, 2021 · 2 comments
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders web Issues related to running VSCode in the web webview Webview issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 1, 2021

image

I think this is not very useful and I can still search using the browser and things get revealed so I suggest to not show this notification.

Related: #96307

@bpasero bpasero added the web Issues related to running VSCode in the web label Jun 1, 2021
@bpasero bpasero added webview-views Webview views in the sidebar and panel webview Webview issues and removed webview-views Webview views in the sidebar and panel labels Jun 1, 2021
@mjbvz mjbvz added this to the June 2021 milestone Jun 1, 2021
@bpasero
Copy link
Member Author

bpasero commented Jun 7, 2021

//cc @rzhao271

@bpasero
Copy link
Member Author

bpasero commented Jun 9, 2021

After having played with dev/mjbvz/iframe-search and seeing the changes there, here are some thoughts for pushing this forward:

  • IFrameWebview as base class of all could own the WebviewFindWidget and provide it for the web and desktop cases
  • implementation for desktop leverages @rzhao271 work with the new Electron support for finding in iframe
  • implementation on web leverages window.find API which I verified actually works in Chrome, Firefox and Safari reasonably well [1]

I was about to prototype this for web, but fail to understand how the iframe preload script gets provided from a CDN it seems. In order to make window.find work the preload script needs to provide a hook (via postMessage?) to run it.

[1]

  • you can find next / find previous
  • find results are highlighted using selection (same as native find)
  • there does not seem to be a way to highlight all results initially
  • I did not find a way to theme the find selection color, so it appears like the normal text selection color

@rzhao271 rzhao271 modified the milestones: June 2021, July 2021 Jun 23, 2021
@mjbvz mjbvz closed this as completed in f7e8474 Jul 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders web Issues related to running VSCode in the web webview Webview issues
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @rzhao271 @mjbvz and others