Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't cursor-past a new fold #125415

Closed
bigjools opened this issue Jun 3, 2021 · 9 comments
Closed

Can't cursor-past a new fold #125415

bigjools opened this issue Jun 3, 2021 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@bigjools
Copy link

bigjools commented Jun 3, 2021

Environment data

  • VS Code version: 1.56.2
  • Extension version (available under the Extensions sidebar): 2021.5.842923320
  • OS and version: Ubuntu 20.04
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): n/a
  • Relevant/affected Python packages and their versions: n/a
  • Relevant/affected Python-related VS Code extensions and their versions: n/a
  • Value of the python.languageServer setting: default (which is set to Pylance)

Expected behaviour

When closing a fold with ctrl-shift-[ and then moving down below the fold, it should not re-open the fold.

Actual behaviour

It re-opens the fold.

Steps to reproduce:

  1. Edit any file with a class that has some function defs in it.
  2. Ctrl-Shift-[ on the first def to close the fold
  3. attempt to move past the fold with down-cursor
  4. Notice it re-opens the fold.

Logs

Not sure this is relevant.

@karthiknadig
Copy link
Member

We don't control the folding UI. This should be on VS Code.

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Jun 3, 2021
@vscodebot
Copy link

vscodebot bot commented Jun 3, 2021

@aeschli aeschli added the info-needed Issue requires more information from poster label Oct 18, 2021
@bigjools
Copy link
Author

Why is this closed, it's still a bug!

@bigjools
Copy link
Author

What info did you need?

@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2021

Hm, looks like my comment didn't get posted.

I'm not able to reproduce. Im placing the cursor at various places, do a cursor down. The folding region is not unfolded.

fold-cursor-move

Can you describe where the cursor is first. Please add a sample.
Also make sure that no extension is causing this.

@bigjools
Copy link
Author

I have the vim extension installed, that could be causing it? I can do zc to close and then cursor down, and it reopens.

@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2021

Yes, that's possible. The VIM extension customizes cursor navigation. Likely a dup of VSCodeVim/Vim#1004

@bigjools
Copy link
Author

Yes that's a dupe. It seems like they want a better API to fix it properly. Happy to close this one as a dupe. Thanks for your attention.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants
@karthiknadig @aeschli @bigjools and others