Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve horizontal screen real-estate #12543

Closed
dilijev opened this issue Sep 23, 2016 · 4 comments
Closed

Improve horizontal screen real-estate #12543

dilijev opened this issue Sep 23, 2016 · 4 comments
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@dilijev
Copy link

dilijev commented Sep 23, 2016

  • VSCode Version: Code - Insiders 1.6.0-insider (0a0bfed, 2016-09-20T06:11:03.267Z)
  • OS Version: Windows_NT ia32 10.0.14915

Steps to Reproduce:

  1. Open code in left and right side editors
  2. Observe the following real-estate usage. Suggestions follow.

image

The blue lines mark the edges of the non-code sidebar for the right-side editor. The line numbers are rendered in dark grey in the same font as the code which is a good thing, no wasted space there. The light grey line to the left of the left blue line is the boundary of the scrollbar. No complaints there -- we can even see code through the scrollbar which is a major plus.

Problem areas are outlined by the red bars. Nothing seems to go in that space (that I've seen so far). The gap between the breakpoint markers and the code folding buttons is unnecessarily large. They are so different in appearance from the numbers there's no chance of confusing them. They can be closer together. When my view is three panels wide I'm losing what feels like a ton of screen space compared to other editors.

Another view which makes this problem more clear:

Set "editor.lineNumbers": false

image

Blue: 50 px for the activity bar (being discussed here)
Green: 45 px for each of the editor's left margin areas - when they are not even displaying line numbers! There's nothing to see there. I'd assert we should not be using all of that horizontal real estate when there's nothing to see.

Let's assume side-by-side editing with two editor panels is a common scenario. Right now there is about 140px of Nothing-To-See-Here space (except when mousing over the margin, where you get the option to fold code and set breakpoints).

Some of this space can be saved as a no-brainer (it's just unnecessary padding):

image

Red bars above are unnecessary padding: 4px, 12px, 5px respectively. Zoomed view:

image

Being able to hide the activity bar would save 50px for those who want to hide it.

Some languages don't support breakpoints. We can save another 10-12px per editor margin for those languages by not reserving that space for the breakpoint icons.

Maybe I'm not interested in folding any code? Add a configuration option or Command to toggle that ability and remove that part of the margin when it won't be used. This saves another 10-11px.

Thanks for listening! :)

@chrmarti chrmarti added the ux User experience issues label Sep 24, 2016
@bgashler1
Copy link
Contributor

May also help with this issue #8871 (placing caret difficult in some cases)

@mjbvz mjbvz assigned stevencl and unassigned bgashler1 Apr 11, 2017
@bpasero bpasero added workbench layout General VS Code workbench layout issues and removed workbench labels Nov 11, 2017
@bpasero bpasero added feature-request Request for new features or functionality editor and removed layout General VS Code workbench layout issues labels Nov 17, 2017
@bpasero bpasero removed their assignment Nov 17, 2017
@alexdima alexdima added diff-editor Diff editor issues and removed diff-editor Diff editor issues labels Nov 23, 2017
@alexdima
Copy link
Member

alexdima commented Nov 23, 2017

"0px" config:

"editor.glyphMargin": false,
"editor.folding": false,
"editor.lineNumbers": "off",
"workbench.activityBar.visible": false
"editor.lineDecorationsWidth": 0, // undocumented
"editor.lineNumbersMinChars": 0,  // undocumented

image

@alexdima alexdima added *question Issue represents a question, should be posted to StackOverflow (VS Code) and removed feature-request Request for new features or functionality ux User experience issues labels Nov 23, 2017
@dilijev
Copy link
Author

dilijev commented Nov 27, 2017

Copying those undocumented settings into my config didn't remove the unnecessary padding for me. Is this supported only on OSX?

image

Current config:

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:32:36.026Z)
  • OS Version: Windows_NT ia32 10.0.15063
    • (not sure why it detected ia32 when VS Code is running 64 bit and I'm on an x64 OS)
  • Extensions: (but running with --disable-extensions)
Extension Author (truncated) Version
xml Dot 1.9.2
gitlens eam 6.2.0
prettier-vscode esb 0.26.0
indentation-level-movement kai 1.1.1
python ms- 0.8.0
cpptools ms- 0.14.2
PowerShell ms- 1.5.1
java red 0.14.0

@dilijev
Copy link
Author

dilijev commented Nov 29, 2017

I found that these settings got rid of most of the margin space:

{
"editor.lineNumbers": "off",
"editor.glyphMargin": false,
"editor.folding": false
}

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

6 participants