Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First class support for inline text (move away from ::after) #125742

Closed
egamma opened this issue Jun 8, 2021 · 2 comments · Fixed by #128337
Closed

First class support for inline text (move away from ::after) #125742

egamma opened this issue Jun 8, 2021 · 2 comments · Fixed by #128337
Assignees
@hediet
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
July 2021

Comments

@egamma
Copy link
Member

egamma commented Jun 8, 2021 •
edited
Loading

related #125324, #125123
@egamma egamma added this to the June 2021 milestone Jun 8, 2021
@hediet hediet added the feature-request Request for new features or functionality label Jun 8, 2021
@hediet hediet mentioned this issue Jun 17, 2021
Closed
@usernamehw usernamehw mentioned this issue Jun 28, 2021
Merged
@hediet hediet modified the milestones: June 2021, July 2021 Jul 1, 2021
@hediet hediet mentioned this issue Jul 10, 2021
Merged
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jul 27, 2021
@rzhao271
Copy link
Contributor

@hediet can you provide some verification steps for this issue (assuming it's not on a testplan item)?

@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Jul 27, 2021
@hediet
Copy link
Member

hediet commented Jul 27, 2021

I created two testplan items for it:

@hediet hediet added on-testplan and removed verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification labels Jul 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Adopt injected text for ghost text microsoft/vscode
4 participants
@egamma @hediet @rzhao271 and others