Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor should render objects with boolean values a list of checkboxes #125958

Closed
rzhao271 opened this issue Jun 10, 2021 · 0 comments
Closed

Settings editor should render objects with boolean values a list of checkboxes #125958

rzhao271 opened this issue Jun 10, 2021 · 0 comments
Assignees
@rzhao271
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2021

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Jun 10, 2021 •
edited
Loading

For settings of type object where all the keys are boolean keys, we should render those settings as a list of checkboxes.

A setting to check this issue with is gitlens.advanced.messages.
Expected behaviour: the settings editor renders that setting as a list of checkboxes.
Actual behaviour: the settings editor does not render that setting. The user must edit that setting in a JSON file.

Code pointer: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/preferences/browser/settingsTreeModels.ts#L611

CC @roblourens
@rzhao271 rzhao271 added the settings-editor VS Code settings editor issues label Jun 10, 2021
@rzhao271 rzhao271 added this to the June 2021 milestone Jun 10, 2021
@rzhao271 rzhao271 self-assigned this Jun 10, 2021
@rzhao271 rzhao271 added the feature-request Request for new features or functionality label Jun 10, 2021
@kieferrm kieferrm mentioned this issue Jun 13, 2021
Closed
72 tasks
@rzhao271 rzhao271 mentioned this issue Jun 14, 2021
Merged
@rzhao271 rzhao271 modified the milestones: June 2021, July 2021 Jun 25, 2021
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jun 28, 2021
@alexr00 alexr00 mentioned this issue Jun 29, 2021
Closed
@alexr00 alexr00 added the verified Verification succeeded label Jun 29, 2021
@rzhao271 rzhao271 added the on-release-notes Issue/pull request mentioned in release notes label Jul 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
3 participants
@rzhao271 @alexr00 and others