Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Inform users that they are running a patched version #12659

Closed
3 tasks done
chrmarti opened this issue Sep 26, 2016 · 0 comments
Closed
3 tasks done

Test: Inform users that they are running a patched version #12659

chrmarti opened this issue Sep 26, 2016 · 0 comments
Assignees

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Sep 26, 2016

Test for #12021

Complexity - 3

Please check in the console that you don't see any warning on startup.

The idea is simple:

  • in product.json there is a checksums field.
  • all the files mentioned in there will be checked
  • this is not a security feature, but a user awareness feature
  • our premise is that end users end up with modified bits on disk and are unaware of it
  • we then spend a lot of time to debug their issues and oftentimes it turns out they don't occur in out-of-the-box versions

Please check:

  • copy somewhere safe workbench.main.js and workbench.main.css
  • modify either one of the files
  • open a new vscode window
  • you should see a popup
  • the text and buttons should make sense.
  • the title adds "[Unsupported]" or something like that
  • the feedback widget contains two more sentences of information
  • restore the safe copies, check that the message doesn't show anymore
  • the More information fwlink is not yet active in the website --> ToDo: Topic on patched bits vscode-docs#607
  • edit the files again
  • click the don't show again, see that we don't pop up again but the title still shows unsupported
@chrmarti chrmarti added this to the September 2016 milestone Sep 26, 2016
@alexdima alexdima removed their assignment Sep 26, 2016
@bpasero bpasero removed their assignment Sep 27, 2016
@sandy081 sandy081 removed their assignment Sep 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants