Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File > Revert File should be disabled for untitled schemes #126999

Closed
bpasero opened this issue Jun 23, 2021 · 6 comments
Closed

File > Revert File should be disabled for untitled schemes #126999

bpasero opened this issue Jun 23, 2021 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2021

Comments

@bpasero
Copy link
Member

bpasero commented Jun 23, 2021

Because that is a no-op.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jun 23, 2021
@bpasero bpasero added this to the June 2021 milestone Jun 23, 2021
@bpasero bpasero self-assigned this Jun 23, 2021
@bpasero
Copy link
Member Author

bpasero commented Jun 23, 2021

//cc @isidorn for how I use context keys, I gave it a brief test and it seems to work fine

@isidorn
Copy link
Contributor

isidorn commented Jun 24, 2021 •
edited
Loading

This looks good.
However I am not 100% sure @alexdima supports A or (B and C)
I believe some time ago for this to work it must have been decomposed into (A or B) and ( A or C). Though it might be some other case that was not working

@alexdima
Copy link
Member

The distribution is done in code in ContextKeyExpr.and, so this should work fine. This distribution was introduced via 350a3c6

@lramos15 lramos15 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Jun 30, 2021
@lramos15
Copy link
Member

File > Revert File is still enabled for untitled schemes

@lramos15 lramos15 reopened this Jun 30, 2021
@bpasero bpasero removed the verification-found Issue verification failed label Jul 1, 2021
@bpasero bpasero closed this as completed in f3d3dbf Jul 1, 2021
@bpasero
Copy link
Member Author

bpasero commented Jul 1, 2021

It looks like the ResourceContextKey cannot really be used globally.

@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2021

@bpasero yeah, that one depends on the explorer focus. I should have caught this earlier...

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2021
@drpicox drpicox mentioned this issue Jul 26, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
6 participants
@bpasero @isidorn @lramos15 @alexdima @rzhao271 and others