Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Supporting iframe search #127173

Closed
3 tasks done
rzhao271 opened this issue Jun 25, 2021 · 2 comments
Closed
3 tasks done

Test: Supporting iframe search #127173

rzhao271 opened this issue Jun 25, 2021 · 2 comments

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Jun 25, 2021

Refs: #96307

Complexity: 3

Authors: @rzhao271, @deepak1556

Create Issue


  1. Add "webview.experimental.useIframes": true to the settings file.
  2. Create a markdown file, or open an existing markdown file.
  3. Run the "Markdown: Open Preview to the Side" command.
  4. Press Ctrl+F to reveal the find widget, and try searching in the iframe.

Some things to try for step 4:

  • How well does searching work with an IME?
  • How well does searching work with a screenreader/a11y tool?
  • Are there any issues if one tries to change the markdown file content, or close and re-open the markdown preview while a find session is in place?
  • Does reloading during a find session cause an issue?
@bamurtaugh
Copy link
Member

Hey @jrieken - I finished up my testing and checked off my name / assignment yesterday. Is it safe to check off yours and close out this issue too? Or was there a reason you assigned it back to me? Thanks!

@jrieken
Copy link
Member

jrieken commented Jun 30, 2021

Yeah, forgot my checkbox here...

@jrieken jrieken closed this as completed Jun 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants