-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger does not step into correct function #127345
Comments
Since this makes me stop wanting to use debug in VSCode, marking as important selfhosting blocker. |
I think this may reproduce in devtools too, so lowering severity. |
I can reproduce this consistently as well. It seems to be a "vanilla" behavior of the version of V8 in Electron. I don't think this is feasible to correct for in the debugger, we'd need to do source analysis and manually set a breakpoint where the function exists (and that will fail if TS doesn't know where the function is declared). However, I don't reproduce it when running the test in real (modern) Chrome. With the introduction of test run configurations in #127096 (comment), I'll have an option to run unit tests in browser to avoid this issue. cc @deepak1556 fyi. You can close this if you don't plan to take any action here (other than pulling in Electron updates) |
@connor4312 which version of chrome did you test with ? Also what are the minimal steps to test this on the web, I can bisect the chrome CL that fixed it and if its minimal will backport to our current version. |
I tested with Chrome 91, by:
|
@connor4312 the issue does not repro in chromium 89 (current runtime of vscode insiders), can you confirm if my steps are correct recording.gif.zip You can download version 89 from https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/843806/chrome-mac.zip |
Okay, sorry, it actually works with stepping, just not breakpoints. Updated instructions:
The bad news is that, with these fixed instructions, I can also reproduce it on modern Chrome 🙁 |
I opened a bug for this here: https://bugs.chromium.org/p/chromium/issues/detail?id=1227841 |
Great, thanks! |
Just FYI, the Chromium bug has been closed as they want a reproducible test case inside Chromium and not in VS Code. |
Steps:
main
src/vs/workbench/services/editor/test/browser/editorService.test.ts
await openEditor(untypedEditor)
=> 🐛 you end up in a weird place
The text was updated successfully, but these errors were encountered: