Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRunner createTestController does not accept runHandler #127566

Closed
joyceerhl opened this issue Jun 29, 2021 · 2 comments
Closed

TestRunner createTestController does not accept runHandler #127566

joyceerhl opened this issue Jun 29, 2021 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@joyceerhl
Copy link
Contributor

Testing #127386

The notebooks namespace provides createNotebookController with the following signature:

export function createNotebookController(id: string, notebookType: string, label: string, handler?: (cells: NotebookCell[], notebook: NotebookDocument, controller: NotebookController) => void | Thenable<void>): NotebookController;

Having used the notebooks API, I expected the test namespace's createTestController to also accept the runHandler as an optional parameter. Its current signature is

export function createTestController(id: string): TestController;
@connor4312
Copy link
Member

Thanks for the issue, however I will close this as a duplicate since this method will be going away with some changes to the runner API in: #127096 (comment) These changes are staged and will be merged after this endgame.

@connor4312 connor4312 added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants
@connor4312 @joyceerhl and others