More contrast to selected line in peek definition

[octref]

Currently it's too hard to tell which line is the one containing the symbol.

Really bad for scanning through.

[jrieken]

@bgashler1 please advice

[bgashler1]

Just from a quick glance at this issue, I would expect this to be a line-highlight, since we're doing that for Search and Find/Replace. Similar concept, in my opinion. Thoughts?

[octref]

Would be best if the line has some shallow highlight like symbol selection:

While the symbol have a strong highlight, like the brown in search.

[bgashler1]

@octref that also makes sense. Similar concept. Why are we using two different grays for these highlights? They seem like they should be the same.

[octref]

@bgashler1 Not two grays. One line of gray background like our-editor, then the strong brown background on the keyword (editor in your case).

[bgashler1]

@octref Sorry for the miscommunication, what I meant was that that the image I posted of a Search match line highlight has a very similar gray to the shallow gray in your image. But when I checked the color values of each, they differed. This is one of many color inconsistencies we have that we should eventually resolve.

[octref]

@bgashler1 That I don't know. Indeed we could use more color consistency.

[jrieken]

The problem is that some provider give us the word too highlight and some providers give us the whole definition range spanning multiple lines. Therefore we fold the highlight into a single position. Unsure what to do next...

[jrieken]

This can be now configured with themes