Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default presentation of Explorer: Copy Relative Path Separator in Setting editor is confusing #128345

Closed
IllusionMH opened this issue Jul 9, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@IllusionMH
Copy link
Contributor

IllusionMH commented Jul 9, 2021

Issue Type: Bug

Would be noticeable on Windows because of (implicit) default \\.

Steps to reproduce:
0. Make sure you are using Windows and reset explorer.copyRelativePathSeparator to default value.

  1. Open Settings view and search for explorer.copyRelativePathSeparator - dropdown has / displayed (and setting not changed - no blue border).
    image

  2. Perform Copy Relative Path - path copied with \\ in it (while dropdown displays /)

  3. Change setting to \\ and then "back" to / - setting now marked as changed
    image

  4. Perform Copy Relative Path - path copied with / in it as expected

I think it's because this setting doesn't have default value and dropdown will display first from list, however implementation has different logic.

VS Code version: Code - Insiders 1.59.0-insider (87d692b, 2021-07-09T05:13:26.890Z)
OS version: Windows_NT x64 10.0.19041
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.72GB (15.15GB free)
Process Argv --crash-reporter-id cf52dbde-2c94-45c3-9bf3-45d8b9966b04
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
pythonvspyt639:30291487
pythontb:30258533
vspre833:30321513
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
vscus158:30321503
pythonvsuse255:30319630
vscorehov:30301224
vscod805cf:30301675
pythonvspyt200:30323110
vscextlangct:30310089
vsccppwt:30312692
bridge0708:30335490

@IllusionMH IllusionMH changed the title Default Explorer: Copy Relative Path Separator presentation in Setting editor is confusing Default presentation of Explorer: Copy Relative Path Separator in Setting editor is confusing Jul 9, 2021
@bpasero bpasero self-assigned this Jul 10, 2021
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jul 10, 2021
@bpasero bpasero added this to the July 2021 milestone Jul 10, 2021
@bpasero
Copy link
Member

bpasero commented Jul 10, 2021

I added a auto default.

//cc @rzhao271 maybe this is a bug for the settings editor: if a setting is a enum without a default, shouldn't the dropdown indicate this by not showing the setting?

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@bpasero @IllusionMH @rzhao271 and others