Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injected text not distinguishable from normal text in HC theme #129678

Closed
isidorn opened this issue Jul 28, 2021 · 5 comments
Closed

Injected text not distinguishable from normal text in HC theme #129678

isidorn opened this issue Jul 28, 2021 · 5 comments
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions verified Verification succeeded
Milestone
October 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2021 •
edited
Loading

Testing #129383

I understand that in HC theme we need strong contrast and thus we can not use a "ghosted" text. However this might mean that we need to have some additional decoration (apart from color) to distinguish that the text is not inserted yet.

Maybe some floating icon would help, or italics?

Screenshot 2021-07-28 at 11 50 11
@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label Jul 29, 2021
@hediet hediet added this to the July 2021 milestone Jul 29, 2021
@hediet hediet modified the milestones: July 2021, August 2021 Jul 30, 2021
@hediet
Copy link
Member

hediet commented Aug 11, 2021

We could add a border around inline suggestions:

image

I don't think italic is enough:

image

@isidorn
Copy link
Contributor Author

isidorn commented Aug 11, 2021

Maybe border + italic?
Since border for me means stronger. And this should not be stronger but lighter..

@hediet hediet modified the milestones: August 2021, September 2021 Aug 26, 2021
@hediet hediet modified the milestones: September 2021, October 2021 Sep 30, 2021
@hediet
Copy link
Member

hediet commented Oct 6, 2021

What about this:

image

(normal ghost text is italic by default now)

@isidorn
Copy link
Contributor Author

isidorn commented Oct 6, 2021

Yeah! I like it.

@hediet
Copy link
Member

hediet commented Oct 7, 2021

Implemented in 3149492.

@hediet hediet closed this as completed Oct 7, 2021
@connor4312 connor4312 added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug inline-completions verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@isidorn @connor4312 @hediet and others