Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly view: migrate to use WorkbenchList #130438

Open
xisui-MSFT opened this issue Aug 9, 2021 · 2 comments
Open

Disassembly view: migrate to use WorkbenchList #130438

xisui-MSFT opened this issue Aug 9, 2021 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@xisui-MSFT
Copy link
Contributor

Migrate to use WorkbenchList since WorkbenchTable doesn't support horizontal scrolling.

Probably should target #129762.

@xisui-MSFT
Copy link
Contributor Author

In the original PR we talked about changing the table to a list, to support horizontal scrolling. However, I wasn't able to find a way to fix the breakpoint column (or elements, since we don't have a column concept in list anymore) from scrolling horizontally. Original discussion: #125737 (comment).

@isidorn Can you help investigating this issue? Thanks!

@isidorn isidorn self-assigned this Aug 10, 2021
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Aug 10, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 10, 2021

Moving to a WorkbenchList to have horizontal scrolling makes overall sense. In order to still have the table like horizontal alignment you will probably need to have fixed "column" sizes in each list row, so they get nicely indented and it looks like a table.

As for having an element always visible when scrolling horizontally: I will probably not have time to look into a solution this milestone. Though I am sure there is a css solution which would solve our problems.
I suggest to add help-wanted to this issue and you provide a code pointer, and somebody from the community will come up with a trick that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants