Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Search/Replace with RegExp with \n only searches in currently open file #13068

Closed
felixfbecker opened this issue Sep 30, 2016 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Sep 30, 2016

  • VSCode Version: 1.5 and 1.6.0-insiders

Steps to Reproduce:

  1. Open project-wide search/replace

  2. Enable regexp searching

  3. Type in a search that includes a new line, like <\?php\n\nnamespace

  4. Hit enter => no results

  5. Open a file where the pattern occurs, like

    <?php
    
    namespace Whatever;
  6. Hit enter again => one result only in this open file

  7. Remove \n\n from query

  8. Hit enter again => all results (files) show up

@felixfbecker felixfbecker changed the title Search/Replace with RegExp with \n only searches in currently open file Project Search/Replace with RegExp with \n only searches in currently open file Sep 30, 2016
@sandy081
Copy link
Member

sandy081 commented Oct 3, 2016

@felixfbecker Currently search works as follows with different code paths.

  • when a file is opened it searches using the same search implementation as the editor find widget (where multi-line search is supported)
  • when a file is not opened it searches in a separate process with a different implementation ((where multi-line search is NOT supported)

Hence you are seeing different results when files are open. I think ideal solution here would be is to support multi-line search in Search view completely #13155

Until then we should not be showing any results for multi line search. More over current shown results for multi line search in Search view are also not good because the matches representations are not correct.

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Oct 3, 2016
@sandy081 sandy081 added this to the October 2016 milestone Oct 3, 2016
@sandy081 sandy081 added the search Search widget and operation issues label Oct 3, 2016
@sandy081 sandy081 modified the milestones: November 2016, October 2016 Oct 26, 2016
@sandy081 sandy081 modified the milestones: Backlog, November 2016 Dec 7, 2016
@ahmetb
Copy link

ahmetb commented Jan 6, 2017

3 months and no fix? Please see #18198 for a very simple use case. It actually is misleading that it says "no results found" whereas the problem is I don't have the files open currently. Either say the feature is not supported, or just implement it please.

@felixfbecker
Copy link
Contributor Author

@ahmetalpbalkan the vscode team is working very hard and there are plenty tickets I would consider higher priority.

@sandy081
Copy link
Member

sandy081 commented Jan 6, 2017

@felixfbecker Thanks for responding.

@ahmetalpbalkan We will try to fix this gap in Find in Files and Editor Find very soon. Thanks for mentioning its importance.

@sandy081 sandy081 added the search-replace Search and replace issues label Dec 4, 2017
@quickEscape
Copy link

@sandy081 "....very soon. ..."

@sandy081 sandy081 removed the search-replace Search and replace issues label May 22, 2018
@sandy081
Copy link
Member

@quickEscape Sorry for that. There were other higher priorities.

@roblourens Please consider this while implementing #13155

@sandy081 sandy081 assigned roblourens and unassigned sandy081 May 22, 2018
@roblourens
Copy link
Member

The most likely path to a fix involves #47058, although the UI still would need updates.

@roblourens
Copy link
Member

I think can be considered a dupe of #13155, sorry if there's something I'm missing

@roblourens roblourens added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Sep 13, 2018
@roblourens roblourens removed this from the Backlog milestone Sep 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

5 participants