Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notebook cell status when cell is collapsed - Example: Show Cell Completed Run Symbol #131200

Closed
gebob19 opened this issue Aug 19, 2021 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-folding notebook-workflow Issues that interrupt expected or desirable behavior verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@gebob19
Copy link

gebob19 commented Aug 19, 2021

In the previous notebook UIs there was a symbol which appeared after the notebook cell finished running. In the most recent version this was removed and now when you run cells which don't have any output (e.g last line in cell: x = fcn(y)) you don't know if it completed or is still running unless you expand the cell output and see the green checkmark.

Feature Request: If we could add a symbol which is visible when a notebook cell finished running while the cell is in collapsed mode that would be awesome.

For example, we can just move the cell run number ([61]) and the green checkmark outside the collapsable cell so they are always visible.

Thanks!

Current UI Cell Collapsed (no completion symbol)
image

Current Bottom-of-Cell UI Expanded (completion symbol visible)
image

@rebornix rebornix added notebook feature-request Request for new features or functionality labels Aug 19, 2021
@rebornix rebornix added this to the On Deck milestone Aug 19, 2021
@DonJayamanne
Copy link
Contributor

I tend to collapse a lot of the cells when running some training. I end up tweeking just one or two cells, and the rest remain un-changed, hence they are all collapsed (as some have outputs as well).
this would be very very useful as I tend to expand cells or look at the execution order to ensure the cells ran (e.g. if i have 23 cells, i check the last cell thats uncollapsed and confirm it has an execution count of 23).

@greazer
Copy link
Member

greazer commented Oct 26, 2021

Related to #135315. Basically there are two requests for being able to see cell status info while it's collapsed.

@greazer greazer changed the title Notebook Cell Completed Run Symbol Show notebook cell status when cell is collapsed - Example: Show Cell Completed Run Symbol Oct 26, 2021
@roblourens
Copy link
Member

#130611 (comment) has a mockup for this

@roblourens
Copy link
Member

For example, we can just move the cell run number ([61]) and the green checkmark outside the collapsable cell so they are always visible.

Actually the thing I linked above isn't what we need for this issue, @misolori have you done mockups for this yet?

@miguelsolorio
Copy link
Contributor

I mocked this up a while ago but it would only show the icon status (not time):

CleanShot 2021-12-17 at 13 32 05@2x

CleanShot 2021-12-17 at 13 31 31@2x

@roblourens
Copy link
Member

I like that. Thanks.

@roblourens roblourens added the verification-needed Verification of issue is requested label Feb 19, 2022
@tanhakabir tanhakabir added the verified Verification succeeded label Feb 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-folding notebook-workflow Issues that interrupt expected or desirable behavior verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@roblourens @rebornix @DonJayamanne @greazer @tanhakabir @gebob19 @miguelsolorio and others