Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly view: show if there is no source #131253

Closed
Trass3r opened this issue Aug 20, 2021 · 6 comments
Closed

Disassembly view: show if there is no source #131253

Trass3r opened this issue Aug 20, 2021 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality

Comments

@Trass3r
Copy link

Trass3r commented Aug 20, 2021

When the source code is not available for whatever reason (missing debug info, missing source file)
VS automatically shows the disassembly. Should be done here too.

Extracted from #129762 (comment)

@vscodebot
Copy link

vscodebot bot commented Aug 20, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality debug-disassembly labels Oct 11, 2021
@weinand
Copy link
Contributor

weinand commented Oct 11, 2021

@yuehuang010 what's your opinion?

@yuehuang010
Copy link
Contributor

In VS, it will show a window to ask user to load symbols, or browse for source files, or show disassembly.
IMO, disassembly is an advance view, it shouldn't be a normal users daily driver. I believe users really prefer trying to load proper symbols and sources than push them to disassembly.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants
@Trass3r @weinand @yuehuang010 and others