Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new terminal reconnection #131453

Closed
3 tasks done
Tyriar opened this issue Aug 23, 2021 · 2 comments
Closed
3 tasks done

Test new terminal reconnection #131453

Tyriar opened this issue Aug 23, 2021 · 2 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2021

Refs: #116113

Complexity: 3

Authors: @Tyriar, @meganrogge

Create Issue


Terminal reconnection has changed, instead of recording a bunch of resize/data events we now run xterm.js on the pty host and leverage the serialize addon to send over a minimal amount of state which improves start up time and allows fine tuning of how much the user wants to restore upon reconnection.

Test the following:

  • Review settings terminal.integrated.persistentSessionExperimentalSerializer and terminal.integrated.persistentSessionScrollback
  • Reload the window and make sure the buffer is restored correctly, try just a regular shell as well as various apps like tmux/vim
  • Disable terminal.integrated.persistentSessionExperimentalSerializer, restart VS Code, fill terminal buffer, reload and make sure ~1000 rows of scrollback are restored
@Tyriar Tyriar added this to the August 2021 milestone Aug 23, 2021
@weinand
Copy link
Contributor

weinand commented Aug 24, 2021

The terminal.integrated.persistentSessionScrollback setting makes sense to me as a user visible configuration.
But terminal.integrated.persistentSessionExperimentalSerializer is just for giving users a chance to go back in case of errors, right? Do we really have to surface this setting (and provide translations etc.)? Shouldn't the test pass find errors in the new serializer?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 24, 2021

@weinand yes that setting is there just in case something goes wrong, the plan is to remove it next month. It's there to mitigate risk and think it's justified.

@weinand weinand removed their assignment Aug 24, 2021
@JacksonKearl JacksonKearl removed their assignment Aug 24, 2021
@DavidKutu DavidKutu removed their assignment Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants