You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Terminal reconnection has changed, instead of recording a bunch of resize/data events we now run xterm.js on the pty host and leverage the serialize addon to send over a minimal amount of state which improves start up time and allows fine tuning of how much the user wants to restore upon reconnection.
Test the following:
Review settings terminal.integrated.persistentSessionExperimentalSerializer and terminal.integrated.persistentSessionScrollback
Reload the window and make sure the buffer is restored correctly, try just a regular shell as well as various apps like tmux/vim
Disable terminal.integrated.persistentSessionExperimentalSerializer, restart VS Code, fill terminal buffer, reload and make sure ~1000 rows of scrollback are restored
The text was updated successfully, but these errors were encountered:
The terminal.integrated.persistentSessionScrollback setting makes sense to me as a user visible configuration.
But terminal.integrated.persistentSessionExperimentalSerializer is just for giving users a chance to go back in case of errors, right? Do we really have to surface this setting (and provide translations etc.)? Shouldn't the test pass find errors in the new serializer?
@weinand yes that setting is there just in case something goes wrong, the plan is to remove it next month. It's there to mitigate risk and think it's justified.
Refs: #116113
Complexity: 3
Authors: @Tyriar, @meganrogge
Create Issue
Terminal reconnection has changed, instead of recording a bunch of resize/data events we now run xterm.js on the pty host and leverage the serialize addon to send over a minimal amount of state which improves start up time and allows fine tuning of how much the user wants to restore upon reconnection.
Test the following:
terminal.integrated.persistentSessionExperimentalSerializer
andterminal.integrated.persistentSessionScrollback
terminal.integrated.persistentSessionExperimentalSerializer
, restart VS Code, fill terminal buffer, reload and make sure ~1000 rows of scrollback are restoredThe text was updated successfully, but these errors were encountered: