Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalStateChangeEvent not used #131496

Closed
isidorn opened this issue Aug 24, 2021 · 2 comments
Closed

TerminalStateChangeEvent not used #131496

isidorn opened this issue Aug 24, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 24, 2021

Testing #130775

We have a TerminalStateChangeEvent but it is not used anywhere. We send a Terminal as part of the state change event
@isidorn
Copy link
Contributor Author

isidorn commented Aug 24, 2021

To be more aligned with the onDidChangeTerminalDimensions I suggest to actually do not send the terminal but the actual TerminalStateChangeEvent

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2021

Thanks, I removed this in the latest iteration but I guess I didn't get rid of the interface. Since Terminal.state exists we don't need the special event as Terminal has all the information needed already.

I think this is an existing pattern in the API but I can bring it up again in the API sync, added a note to #127717

@Tyriar Tyriar mentioned this issue Aug 24, 2021
Closed
@Tyriar Tyriar closed this as completed in 2eee67f Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@isidorn @Tyriar @meganrogge and others