Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to documentSelector for HTML with a custom language id #131531

Closed
angelozerr opened this issue Aug 24, 2021 · 1 comment
Closed

Contribute to documentSelector for HTML with a custom language id #131531

angelozerr opened this issue Aug 24, 2021 · 1 comment
Assignees

Comments

@angelozerr
Copy link
Contributor

There are a lot of issues about how to use HTML language service with custom language to benefit with HTML language feature but all solution works if you are in TypeScript Land.

I have a language server written in Java and I have a custom language id bind with this language server. I would like to benefit with completion,validation, etc from HTML and the only solution that I see is to give the capability to contribute to documentSelector like suggested in #88377 (comment)

let documentSelector = ['html', 'handlebars'];

We had the same problem with our project vscode-microprofile and we give the capability to contribute to document selector from package.json

Here the code which create documentSelector https://github.com/redhat-developer/vscode-microprofile/blob/9cddbc13541c50fce9f44199374eccc2d7d9a274/src/extension.ts#L167

Here a sample of package.json which contribute to document selector https://github.com/redhat-developer/vscode-quarkus/blob/9cb7a2dfcb2c503a7dbac910e0c5765283dda860/package.json#L66

If HTML could provide this feature,it should be fantastic.

@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2021

#49210 is the issue to bind a language id to html so it inherits the HTML language capabilities

I always wanted to add that, but haven't been able to get the time for it.
If someone wants to work on a PR with a proposal, that would be great.

Closing as a dup of #49210

@aeschli aeschli closed this as completed Aug 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants