Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrated.defaultProfile.linux is ignored for the first terminal opened in a remote-ssh window #131790

Closed
WyattGosling opened this issue Aug 19, 2021 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) remote Remote system operations issues terminal General terminal issues that don't fall under another label terminal-profiles
Milestone

Comments

@WyattGosling
Copy link

  • VSCode Version: 1.59.0
  • Local OS Version: macOS 11.4 (Big Sur)
  • Remote OS Version: Red Hat Enterprise Linux Server release 7.7 (Maipo)
  • Remote Extension/Connection Type: SSH
  • Logs: I'm not sure what to provide.

Steps to Reproduce:

  1. Determine the user's default shell on the remote server (for me, it's bash)
  2. Set terminal.integrated.defaultProfile.linux to a shell that isn't the above (fish)
  3. Use the remote-ssh plugin to connect to the same server used in step 1.
  4. Create a terminal window.
  5. Observe that the shell from step 1 is used. (incorrect)
  6. Create additional terminal windows.
  7. Observe these use the shell configured in step 2.

Does this issue occur when you try this locally?: No.
Does this issue occur when you try this locally and all extensions are disabled?: No

I cannot reproduce this locally. It happens every time remotely. The issue occurs even when manually disabling all extensions except for "Remote - SSH" and "Remote - SSH: Editing Configuration Files".

@bamurtaugh
Copy link
Member

cc @Tyriar @meganrogge

@andyj513
Copy link

I believe I'm seeing the same issue. I saw that "terminal.integrated.shell.linux" was now deprecated, so I removed it and created two shells in "terminal.integrated.profiles.linux" (bash and tmux) and set "terminal.integrated.defaultProfile.linux": "tmux".

When I start VS Code with my remote workspace, a terminal window appears (because the terminal window was open when I closed VS Code), which is not tmux (it seems to be bash). If I then close (with exit) that terminal and press Ctrl-` to open a new terminal, it is tmux. The bug is that the first terminal that is opened by default (restoring the previous state) does not use tmux -- my set default. But the default is used for all further terminals (until I close VS Code and start it again).

Note that when I close VS Code with the (tmux) terminal open -- the restart is ignoring both the type of terminal I previously had opened and the default. If I close the terminal panel before closing VS Code, then when I restart there is no terminal window (as expected), and Ctrl-` opens the terminal panel with tmux. Since the terminal window only appears initially when there was one when I closed the Workspace, I believe that restoring the same type of terminal would also solve this bug and might be better (instead of having it use the default).

@Tyriar Tyriar transferred this issue from microsoft/vscode-remote-release Aug 27, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug confirmation-pending remote Remote system operations issues terminal General terminal issues that don't fall under another label terminal-profiles labels Aug 27, 2021
@Tyriar Tyriar added this to the Backlog milestone Aug 27, 2021
@tgodzik
Copy link

tgodzik commented Sep 10, 2021

I have the sam issue in a normal Linux environment. I checked the insiders and the issue persists.

@samgrandad
Copy link

I'm seeing the same issue in a local Windows environment - it always opens Powershell first even though Git Bash is the default profile.

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2021

@samgrandad that's #132150

@tisswb
Copy link

tisswb commented Sep 15, 2021

same issue

@YunHsiao
Copy link

@samgrandad that's #132150

I don't think it is, I can confirm my local windows environment has this issue way before the 1.60 release, please investigate.

@dryhurst
Copy link

confirming same behavior windows 10 Pro v20H2 build: 19042.1237

@Trouler
Copy link

Trouler commented Sep 15, 2021

Been having this issue for slighty over a week now.

VSCode 1.60.0
Windows 10 Enterprise v20H2 build: 19042.1165

@meganrogge
Copy link
Contributor

/duplicate #132150

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) remote Remote system operations issues terminal General terminal issues that don't fall under another label terminal-profiles
Projects
None yet
Development

No branches or pull requests

12 participants