Support link detection for in notebook error output

[DonJayamanne]

@nfx commented on Sat Feb 27 2021

Issue Type: Bug

Let's imagine some hypothetical bad code that resulted in exception either because bad or unfamiliar third-party libraries and focus on speed of issue resolution:

import pandas as pd
pd.DataFrame(42)

Upon executing this, we get an exception. As professional IDE user, I expect a consistent behavior and exception stack trace rendered like a normal stack trace - something compact, with clickable lines, that get me to correct lines of code, causing the error. I do not want to open search bar in the project, then figure out that this is not the error in the project i'm working on, but rather in third-party dependency, because that way i have to go, figure out where the sources of that dependency are, open another editor, find references, etc etc. I also really don't want to see the same exception message for 3 times. Practically speaking, we can make hiding of stack traces as opt-out feature. If make with bottom-right notifications popup - even better :)

VSCode has a nice stack trace rendering widget in debug mode, so that one could be just re-used in this beautiful extension, so that I'd see consistent UX across different parts of the editor for the same type of things.

...

Extension version: 2021.3.600686576
VS Code version: Code - Insiders 1.54.0-insider (Universal) (e590188, 2021-02-26T20:39:12.763Z)
OS version: Darwin x64 19.6.0

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvspyt639:30264824
pythontb:30258533

---

@nfx commented on Sat Feb 27 2021

Must be part of #91987

---

@joyceerhl commented on Sat Feb 27 2021

Thanks for the feedback @nfx. Possible dupe of microsoft/vscode-jupyter#4589

---

@nfx commented on Sun Feb 28 2021

@joyceerhl this one has more details 😜

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Cannot go to sources of exception stack trace (#118140)

[DonJayamanne]

@rebornix @jrieken /cc
Feature request.

[rebornix]

Only Jupyter understands the error links correctly, let's do this in the error renderer.

[DonJayamanne]

Only Jupyter understands the error links correctly

@rebornix
This is not true. We get link detection in terminals today for Python stack traces in terminal outputs (handle by VSCode core). Hence I believe it can be done in core as well.

FYI - This is a feature request from users.

[vscodenpa]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

[rebornix]

Let's track it in microsoft/vscode-jupyter#12285