Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Running Extensions in a grid #133136

Open
lychung7 opened this issue Sep 15, 2021 · 1 comment
Open

Show Running Extensions in a grid #133136

lychung7 opened this issue Sep 15, 2021 · 1 comment
Assignees
Labels
extension-host Extension host issues feature-request Request for new features or functionality
Milestone

Comments

@lychung7
Copy link
Contributor

Summary of current experience

The current Show Running Extensions experience lays out a list of running extensions similar to how it is laid out for extensions shown in the side bar. There is left and right-aligned text as well as secondary information for certain extensions. Actions in the top-right include Run code, Save extension host profile (disabled until profiling is finished), Debug extension host, and Start extension host profile.

image

After you start and then stop the extension host profile, the profile time populates in the list underneath the activation time and the save profile icon is enabled. The saving and viewing experience includes a few steps. The default extension the file is saved as is “.cpuprofile.txt”. If you want to open the file in VS Code to inspect after you save the file, you have to manually change the extension to “.cpuprofile” and open it in VS Code.

Once the file is opened, you can click on the flame view which opens up an additional file that has the same name as the original file opened.

Idea

Show.running.extensions.mov

A proposed change is that we could display the running extensions in a grid. The icons in the top-right corner have also been changed. Debug extension host is using the debug icon rather than the green triangle icon to better differentiate from the Run code icon. I also made a small tweak to the Start extension host profile icon for visual consistency and weight across the icons. There is also no save profile icon because once the profiling is finished, an untitled file could automatically show up in a new tab to view. I was also wondering if we can switch to flame view within the same file rather than opening up another tab for this view. From here, a user could save the file with the extension they prefer.

@alexdima alexdima added the feature-request Request for new features or functionality label Sep 27, 2021
@alexdima alexdima added this to the Backlog milestone Sep 27, 2021
@alexdima alexdima changed the title Show Running Extensions Show Running Extensions in a grid Sep 27, 2021
@alexdima alexdima added the extension-host Extension host issues label Sep 27, 2021
@lychung7
Copy link
Contributor Author

lychung7 commented Oct 7, 2021

Updated iteration

Update-running.extensions.mov

Grid:

  • On hover ellipsis shown in the first column for context menu.
  • Info icon and on-hover information for cells with Startup activation within the Activation column

CPU Profile:

  • Updated layout of information
  • Included percentage with self and total time
  • In the video, the text in the time columns are right-aligned. Some other explorations include left-aligning all columns and left-aligning all columns with the highlight. I'm wondering which is the most readable.

Left-aligned
Left-aligned-with highlight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-host Extension host issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants