Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should be aware when a command execution finishes #13351

Closed
isidorn opened this issue Oct 7, 2016 · 1 comment
Closed

Terminal should be aware when a command execution finishes #13351

isidorn opened this issue Oct 7, 2016 · 1 comment
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 7, 2016 •
edited
Loading

Currently we support having a preLaunchTask specified in 'launch.json' to run a task before a user starts debugging (more details here). There are requests that we support running a preLaunchTask even if a user does not have 'tasks.json' setup.

My proposal for this is that the user could specify a full command in his 'launch.json' which we would just forward to our terminal via the send api. The only missing piece for this would be for the terminal to be aware when a command has finished running - or when it becomes idle. Currently this problem is solved in the task framewrok by @dbaeumer so maybe we could do something similar in our terminal.

I think @jrieken might be also interested in something similar for the passing of errors from our terminal to the marker service.

@Tyriar let me know what you think and if this request makes sense
@weinand fyi
@isidorn isidorn added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Oct 7, 2016
@isidorn isidorn changed the title Terminal should be aware when a command execution finished Terminal should be aware when a command execution finishes Oct 7, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 7, 2016

This is basically a duplicate of #11422, I'll reply over there.

@Tyriar Tyriar mentioned this issue Oct 7, 2016
Closed
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 7, 2016
@Tyriar Tyriar closed this as completed Oct 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isidorn @Tyriar