acceptSuggestionOnCommitCharacter with ghost text

[TylerLeonhardt]

Testing #133907

So I just realized that acceptSuggestionOnCommitCharacter is on by default, this means that when you hit ; at this point:

it will accept the completion (not the inline completion):

I wanted to call this out because I think it's worth discussing... do you think that ; would accept only the completion or the whole suggestion?

In my eyes, a ; is saying "I wanna commit to this whole statement" and so I might expect that the inline completion would also be accepted. This might be a nice way for a user to accept the completion and the inline completion in one keystroke (if such a thing doesn't exist already).

What do you think @hediet?

[hediet]

Would the semicolon be added twice then?

[TylerLeonhardt]

I would say no. If there's a ; at the end of an online completion then don't add a 2nd?