Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviving terminal process not working on Windows #134063

Closed
karrtikr opened this issue Sep 28, 2021 · 8 comments
Closed

Reviving terminal process not working on Windows #134063

karrtikr opened this issue Sep 28, 2021 · 8 comments
Assignees
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues

Comments

@karrtikr
Copy link
Contributor

Testing #133516

Maybe I misunderstand what processes are supposed to be restored, but I ran these processes,

  • yarn run compile
  • yarn run test
  • python hello.py which exits after 30 seconds
import time

print("Printed immediately.")
time.sleep(30)
print("Printed after 30 seconds.")

used workbench.action.quit command to exit, but only the buffer is restored.

image

Is this expected?

@meganrogge
Copy link
Contributor

According to this, I'd expect it to work

#131634 (comment)

@meganrogge
Copy link
Contributor

Perhaps these particular processes aren't recreated and that's by design. I'm not sure.

@meganrogge meganrogge added the terminal Integrated terminal issues label Sep 28, 2021
@meganrogge meganrogge added this to the October 2021 milestone Sep 28, 2021
@karrtikr
Copy link
Contributor Author

It works when I reload the window, but not when exiting or closing and reopening the window, so I guess that comment is still accurate.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Oct 1, 2021
@meganrogge meganrogge removed this from the October 2021 milestone Oct 4, 2021
@meganrogge
Copy link
Contributor

Clarified with @Tyriar and this is working as-designed.

@karrtikr
Copy link
Contributor Author

karrtikr commented Oct 4, 2021

I see, can you give me some examples of processes it is supposed to restore?

@Tyriar
Copy link
Member

Tyriar commented Oct 4, 2021

@karrtikr I think the confusion is it doesn't "restore" processes, it restores the buffer, and then re-created a new process at what we know the current working directory to be (cwd detection is not supported right on Windows so it uses the initial directory).

@karrtikr
Copy link
Contributor Author

karrtikr commented Oct 4, 2021

Got it, thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @karrtikr @meganrogge and others