-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviving terminal process not working on Windows #134063
Comments
According to this, I'd expect it to work |
Perhaps these particular processes aren't recreated and that's by design. I'm not sure. |
It works when I reload the window, but not when exiting or closing and reopening the window, so I guess that comment is still accurate. |
Clarified with @Tyriar and this is working as-designed. |
I see, can you give me some examples of processes it is supposed to restore? |
@karrtikr I think the confusion is it doesn't "restore" processes, it restores the buffer, and then re-created a new process at what we know the current working directory to be (cwd detection is not supported right on Windows so it uses the initial directory). |
Got it, thanks. |
Testing #133516
Maybe I misunderstand what processes are supposed to be restored, but I ran these processes,
yarn run compile
yarn run test
python hello.py
which exits after 30 secondsused
workbench.action.quit
command to exit, but only the buffer is restored.Is this expected?
The text was updated successfully, but these errors were encountered: