-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet completion doesn't work after button with (click) event in typescript with Angular 2.0 #13414
Comments
Issue is still there with the new 1.6 release |
@Nikki1993 I am trying to get a repro. Here is what I did:
Am I missing something? |
@ramya-rao-a with all the stuff done, now add a click event to the button aka |
Hm, I just tried to do it in VSCode 1.10 and it seems like Emmet completions are not triggered at all inside template. No matter what/where I type. Could have been caused by another extension, can't remember anymore it's been months. |
That's exactly what I see. And I dont have any extensions, so its not due to extensions that the feature stopped working. Honestly, I didnt even know emmet worked at all inside the template |
Is it possible that the completion you were seeing before was a feature of an extension? |
Also, one way you could get emmet features is to add the below in the settings
Note: this will enable emmet expnasion in the whole file. So
|
Closing this issue, as emmet expansions never worked inside template strings to begin with. |
In the new emmet model that we are working on, extensions can now ask for emmet abbreviations in their completion provider. Therefore, this feature request is now an extension candidate. See #29114 (comment) for how to use the vscode-emmet-helper to get emmet abbreviation completions All the extension needs to do is identify the areas of code where html completions are required. Like |
We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines. Happy Coding! |
Steps to Reproduce:
template:
have something like<button (click)="test = 'Emmet works'"></button>
If you try to use tab completion before the aforementioned button click it will auto-complete correctly.
Removing the (click) part fixes the autocompletion.
The text was updated successfully, but these errors were encountered: