Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reporter does nothing when "Create on GitHub" is pressed #134530

Closed
0xabu opened this issue Oct 6, 2021 · 7 comments
Closed

Issue reporter does nothing when "Create on GitHub" is pressed #134530

0xabu opened this issue Oct 6, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues

Comments

@0xabu
Copy link
Contributor

0xabu commented Oct 6, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version:
    1.60.2
  • OS Version:
    Windows 11 x64 22000

Steps to Reproduce:

  1. Help -> Report Issue
  2. Fill out the report as shown:
    image
  3. Click "Create on GitHub"
    (nothing happens)
@0xabu
Copy link
Contributor Author

0xabu commented Oct 6, 2021

(I was obviously trying to report a real issue before this dummy one.)

@TylerLeonhardt
Copy link
Member

Interesting. I can't repro this as you can see here: #134813

I'm wondering if your login session has become invalid somehow... can you share with me what's in the Console in Dev Tools in the issue reporter:

  • Issue reporter in focus
  • Ctrl + Shift + I
  • Console tab

And in the editor window:

  • Ctrl + Shift + P
  • Developer: Toggle Developer Tools
  • Console tab

@TylerLeonhardt TylerLeonhardt added the info-needed Issue requires more information from poster label Oct 11, 2021
@0xabu
Copy link
Contributor Author

0xabu commented Oct 11, 2021

Just reproed it again on 1.61.0

Issue reporter console shows three access denied errors:

Access to fetch at 'https://vscode-probot.westus.cloudapp.azure.com:7890/duplicate_candidates' from origin 'vscode-file://vscode-app' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
vscode-probot.westus.cloudapp.azure.com:7890/duplicate_candidates:1 Failed to load resource: net::ERR_FAILED
issueReporterMain.ts:816 POST https://api.github.com/repos/Microsoft/vscode/issues 403

Editor console shows only one warning, probably irrelevant:

DevTools failed to load source map: Could not load content for https://ticino.blob.core.windows.net/sourcemaps/ee8c7def80afc00dd6e593ef12f37756d8f504ea/core/vs/workbench/workbench.desktop.main.js.map: Load canceled due to load timeout

@0xabu
Copy link
Contributor Author

0xabu commented Oct 11, 2021

@TylerLeonhardt

The second 403 response has a body of:

{
  "message": "Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization.",
  "documentation_url": "https://docs.github.com/articles/authenticating-to-a-github-organization-with-saml-single-sign-on/"
}

probably because I'm in the Microsoft org, and there's the SSO stuff with github?

@TylerLeonhardt
Copy link
Member

Ahh good to know. Yes. I need to set up prompting for you to sign in again if the SSO session expires. As a work around, you can sign out of GitHub in vscode and sign back in and you should be unblocked.

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues and removed info-needed Issue requires more information from poster labels Oct 11, 2021
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Oct 11, 2021
@altano
Copy link

altano commented Sep 2, 2023

Signing out and signing back in does not fix the already-open issue reporter, and the already-open issue reporter has captured information about my extension bisect that I lose when I close it (the bisect is how I ended up in the Issue Reporter). Also when I close and re-open the Issue Reporter, the extension is disabled (automatically, as a result of it being the culprit that the extension bisect discovered) so I can't even pick it in the new Issue Reporter instance. So, this workaround isn't ideal and it might be the case that bug reports are just not getting filed by the extension bisect tool (which is fantastic, btw).

This is the error I see in the dev console after signing-out and back in and then click the "Create GitHub Issue" button again, in the existing issue reporter:

   ERR [uncaught exception in main]: Invalid URL: Error: Invalid URL
    at D.openExternal (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:88:74913)
    at Object.call (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:25:4844)
    at P.s (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:23:5128)
    at P.q (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:23:4644)
    at o.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:23:4051)
    at b.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:1906)
    at b.x (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:1976)
    at b.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:2192)
    at o.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:16:38681)
    at b.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:1906)
    at b.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:2123)
    at o.value (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:16:38875)
    at b.w (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:1906)
    at b.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:18:2123)
    at se (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:16:41018)
    at IpcMainImpl.f (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:19:96331)
    at IpcMainImpl.emit (node:events:525:35)
    at EventEmitter.<anonymous> (node:electron/js2c/browser_init:2:80979)
    at EventEmitter.emit (node:events:513:28)

@justschen justschen mentioned this issue Dec 7, 2023
@justschen
Copy link
Contributor

justschen commented Dec 7, 2023

@0xabu was unable to reproduce on 1.84.2

@altano There have been a few changes to the issue reporter, if the issue persists, please create a new issue since your issue is slightly unrelated.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues
Projects
None yet
Development

No branches or pull requests

5 participants