Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift enter to empty cell doesn't place the new cell in a visible location on screen #134607

Closed
IanMatthewHuff opened this issue Oct 5, 2021 · 5 comments
Assignees
Labels
notebook-layout under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@IanMatthewHuff
Copy link
Member

Not 100% sure what's happening here, but it might just be the output arriving and pushing down the focused cell. But it's not a good shift enter experience as my cell focus is on the next cell, but I can't see it on screen at all.

ShiftEnterFocus

@rchiodo rchiodo transferred this issue from microsoft/vscode-jupyter Oct 7, 2021
@rchiodo rchiodo added this to the October 2021 milestone Oct 7, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 7, 2021

This is a VS code core issue.

@rebornix rebornix assigned rebornix and unassigned rebornix Oct 11, 2021
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-layout labels Oct 11, 2021
@rebornix rebornix assigned roblourens and unassigned rebornix Oct 11, 2021
@roblourens
Copy link
Member

roblourens commented Oct 11, 2021

This can happen in Jupyter lab too. What happens here is:

  1. Insert cell B below and reveal it
  2. Clear the output on cell A
  3. Insert the output on cell A, since it is visible and changing its height, we maintain its scroll position
  4. Now cell B is pushed out of the viewport

I think in this scenario it is by design. My understanding of what happens in shift+enter is that the focus is really still on cell A. But I don't understand why people want it to work that way.

@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Oct 26, 2021
@rebornix rebornix modified the milestones: October 2021, On Deck Oct 26, 2021
@rebornix rebornix removed their assignment Dec 30, 2022
@rebornix
Copy link
Member

There is another request microsoft/vscode-jupyter#5186 which asks for exactly the opposite.

@roblourens
Copy link
Member

Exactly, but Jupyter lab's behavior doesn't make sense to me

@rebornix
Copy link
Member

Playing around this again, what VS Code does now is, shift+enter reveals cell B in center and focuses it, since it's focused cell, the height change of cell A won't change the visual position of cell B. @roblourens correct me if it's not the behavior you would expect.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-layout under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants