Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different border settings for vertical or horizontal layouts, for in-group editor splitting #135110

Closed
a5hk opened this issue Oct 14, 2021 · 2 comments · Fixed by #135181
Closed

Support different border settings for vertical or horizontal layouts, for in-group editor splitting #135110

a5hk opened this issue Oct 14, 2021 · 2 comments · Fixed by #135181
Assignees
@bpasero
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
October 2021

Comments

@a5hk
Copy link
Contributor

a5hk commented Oct 14, 2021

There is a new color sideBySideEditor.border which can be used when we split an editor in group. The layout can be horizontal or vertical. Please support different border color settings for vertical and horizontal layouts.
For example in the following vertical layout I don't need/want any border. It is easy to distinguish each editor.

v

But it is hard to distinguish editors in horizontal layout without a border.

h
@a5hk a5hk changed the title Support different border settings for vertical or horizontal in group splitting Support different border settings for vertical or horizontal layouts in group splitting Oct 14, 2021
@a5hk a5hk changed the title Support different border settings for vertical or horizontal layouts in group splitting Support different border settings for vertical or horizontal layouts, for in group editor splitting Oct 14, 2021
@a5hk a5hk changed the title Support different border settings for vertical or horizontal layouts, for in group editor splitting Support different border settings for vertical or horizontal layouts, for in-group editor splitting Oct 14, 2021
@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Oct 15, 2021
@bpasero bpasero added the themes Color theme issues label Oct 15, 2021
@bpasero bpasero added this to the Backlog milestone Oct 15, 2021
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Oct 15, 2021
@bpasero
Copy link
Member

bpasero commented Oct 15, 2021

Sounds reasonable, open for help for a meaningful small PR.

This was referenced Oct 15, 2021
Closed
Merged
@bpasero bpasero modified the milestones: Backlog, October 2021 Oct 23, 2021
@bpasero bpasero self-assigned this Oct 23, 2021
@bpasero bpasero added the verification-needed Verification of issue is requested label Oct 23, 2021
@bpasero
Copy link
Member

bpasero commented Oct 23, 2021

Verification:

  • configure colors for the new theme colors sideBySideEditor.horizontalBorder and sideBySideEditor.verticalBorder and verify they apply properly as advertised depending on the split in group layout

@connor4312 connor4312 added the verified Verification succeeded label Oct 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
October 2021
5 participants
@bpasero @connor4312 @a5hk @sbatten and others