Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal looks strange when dragged into side panel #135919

Closed
joyceerhl opened this issue Oct 27, 2021 · 4 comments
Closed

Terminal looks strange when dragged into side panel #135919

joyceerhl opened this issue Oct 27, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.62-insider
  • OS Version: Windows 11

Steps to Reproduce:

  1. Drag terminal tab into new side panel gated on workbench.experimental.sidePanel.enabled setting
  2. Side panel background color and terminal area background color don't match up, so the terminal looks rather out of place in the side panel
    image versus in the terminal area panel with a split container
    image
  3. There seems to be missing left padding so the terminal area is dedented relative to the chevron guide
    image This is what it looks like in the terminal area panel by contrast
    image
@gjsjohnmurray
Copy link
Contributor

Maybe f9943ec will fix this. Please retest when you get the next Insiders build.

@Tyriar
Copy link
Member

Tyriar commented Oct 27, 2021

Looks like this should be working based on this:

const panelBackgroundColor = theme.getColor(TERMINAL_BACKGROUND_COLOR) || theme.getColor(PANEL_BACKGROUND);
collector.addRule(`.monaco-workbench .part.panel .pane-body.integrated-terminal .terminal-outer-container { background-color: ${panelBackgroundColor ? panelBackgroundColor.toString() : ''}; }`);
const sidebarBackgroundColor = theme.getColor(TERMINAL_BACKGROUND_COLOR) || theme.getColor(SIDE_BAR_BACKGROUND);
collector.addRule(`.monaco-workbench .part.sidebar .pane-body.integrated-terminal .terminal-outer-container { background-color: ${sidebarBackgroundColor ? sidebarBackgroundColor.toString() : ''}; }`);

@joyceerhl
Copy link
Contributor Author

Hm, still looks like this in Insiders from 0f7f6e3
image

@sbatten
Copy link
Member

sbatten commented Oct 27, 2021

@Tyriar that theming doesn't apply to the side panel which currently uses side bar theming. Right now the name of the part in css land is .part.auxiliarybar

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar modified the milestones: November 2021, October 2021 Oct 28, 2021
@Tyriar Tyriar closed this as completed in 1bb8780 Oct 28, 2021
@tanhakabir tanhakabir added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants
@Tyriar @sbatten @gjsjohnmurray @tanhakabir @meganrogge @joyceerhl and others